base/BUILD.gn - Issue 1140153005: ICU msg format support with more than one arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 1140153005: ICU msg format support with more than one arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 6866707c2db4129ad517c1974d81357b6ced3f00..13e0195005a5b7e199eb7a38771e478935153a54 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -966,6 +966,8 @@ component("i18n") {

"i18n/icu_string_conversions.h",

"i18n/icu_util.cc",

"i18n/icu_util.h",

+ "i18n/message_formatter.cc",

+ "i18n/message_formatter.h",

"i18n/number_formatting.cc",

"i18n/number_formatting.h",

"i18n/rtl.cc",

@@ -1236,6 +1238,7 @@ test("base_unittests") {

"i18n/char_iterator_unittest.cc",

"i18n/file_util_icu_unittest.cc",

"i18n/icu_string_conversions_unittest.cc",

+ "i18n/message_formatter_unittest.cc",

"i18n/number_formatting_unittest.cc",

"i18n/rtl_unittest.cc",

"i18n/streaming_utf8_validator_unittest.cc",

« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/base.gyp » ('J')