ICU msg format support with more than one arguments

ui/base/l10n/l10n_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/l10n/l10n_util.h"
 
 #include <algorithm>
 #include <cstdlib>
 #include <iterator>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_util.h"
 #include "base/i18n/file_util_icu.h"
+#include "base/i18n/message_formatter.h"
 #include "base/i18n/rtl.h"
 #include "base/i18n/string_compare.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "third_party/icu/source/common/unicode/rbbi.h"
 #include "third_party/icu/source/common/unicode/uloc.h"
 #include "ui/base/l10n/l10n_util_collator.h"
-#include "ui/base/l10n/l10n_util_plurals.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_paths.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/locale_utils.h"
 #include "ui/base/l10n/l10n_util_android.h"
 #endif
 
 #if defined(USE_GLIB)
 #include <glib.h>
@@ skipping 777 matching lines @@
 
 base::string16 GetStringFUTF16Int(int message_id, int a) {
   return GetStringFUTF16(message_id, base::UTF8ToUTF16(base::IntToString(a)));
 }
 
 base::string16 GetStringFUTF16Int(int message_id, int64 a) {
   return GetStringFUTF16(message_id, base::UTF8ToUTF16(base::Int64ToString(a)));
 }
 
 base::string16 GetPluralStringFUTF16(int message_id, int number) {
-  base::string16 pattern = GetStringUTF16(message_id);
-  UErrorCode err = U_ZERO_ERROR;
-  icu::MessageFormat format(
-      icu::UnicodeString(FALSE, pattern.data(), pattern.length()), err);
-  icu::UnicodeString result_unistring;
-  FormatNumberInPlural(format, number, &result_unistring, &err);
-  int capacity = result_unistring.length() + 1;
-  DCHECK_GT(capacity, 1);
-  base::string16 result;
-  result_unistring.extract(
-      static_cast<UChar*>(base::WriteInto(&result, capacity)), capacity, err);
-  DCHECK(U_SUCCESS(err));
-  return result;
+  return base::i18n::MessageFormatter::FormatWithNumberedArgs(
+      GetStringUTF16(message_id), number);
 }
 
 std::string GetPluralStringFUTF8(int message_id, int number) {
   return base::UTF16ToUTF8(GetPluralStringFUTF16(message_id, number));
 }
 
+base::string16 GetSingleOrMultipleStringUTF16(int message_id,
+                                               bool is_multiple) {
+  return base::i18n::MessageFormatter::FormatWithNumberedArgs(
+      GetStringUTF16(message_id), is_multiple ? "multiple" : "single");
+}
+
 void SortStrings16(const std::string& locale,
                    std::vector<base::string16>* strings) {
   SortVectorWithStringKey(locale, strings, false);
 }
 
 const std::vector<std::string>& GetAvailableLocales() {
   return g_available_locales.Get();
 }
 
 void GetAcceptLanguagesForLocale(const std::string& display_locale,
@@ skipping 17 matching lines @@
 
 const char* const* GetAcceptLanguageListForTesting() {
   return kAcceptLanguageList;
 }
 
 size_t GetAcceptLanguageListSizeForTesting() {
   return arraysize(kAcceptLanguageList);
 }
 
 }  // namespace l10n_util