Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: base/i18n/message_formatter.cc

Issue 1140153005: ICU msg format support with more than one arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark's review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/i18n/message_formatter.h ('k') | base/i18n/message_formatter_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/i18n/message_formatter.h"
6
7 #include "base/logging.h"
8 #include "base/numerics/safe_conversions.h"
9 #include "base/time/time.h"
10 #include "third_party/icu/source/common/unicode/unistr.h"
11 #include "third_party/icu/source/common/unicode/utypes.h"
12 #include "third_party/icu/source/i18n/unicode/fmtable.h"
13 #include "third_party/icu/source/i18n/unicode/msgfmt.h"
14
15 using icu::UnicodeString;
16
17 namespace base {
18 namespace i18n {
19 namespace {
20 UnicodeString UnicodeStringFromStringPiece(StringPiece str) {
21 return UnicodeString::fromUTF8(
22 icu::StringPiece(str.data(), base::checked_cast<int32_t>(str.size())));
23 }
24 } // anonymous namespace
25
26 namespace internal {
27 MessageArg::MessageArg() : formattable(nullptr) {}
28
29 MessageArg::MessageArg(const char* s)
30 : formattable(new icu::Formattable(UnicodeStringFromStringPiece(s))) {}
31
32 MessageArg::MessageArg(StringPiece s)
33 : formattable(new icu::Formattable(UnicodeStringFromStringPiece(s))) {}
34
35 MessageArg::MessageArg(const std::string& s)
36 : formattable(new icu::Formattable(UnicodeString::fromUTF8(s))) {}
37
38 MessageArg::MessageArg(const string16& s)
39 : formattable(new icu::Formattable(UnicodeString(s.data(), s.size()))) {}
40
41 MessageArg::MessageArg(int i) : formattable(new icu::Formattable(i)) {}
42
43 MessageArg::MessageArg(int64_t i) : formattable(new icu::Formattable(i)) {}
44
45 MessageArg::MessageArg(double d) : formattable(new icu::Formattable(d)) {}
46
47 MessageArg::MessageArg(const Time& t)
48 : formattable(new icu::Formattable(static_cast<UDate>(t.ToJsTime()))) {}
49
50 MessageArg::~MessageArg() {}
51
52 // Tests if this argument has a value, and if so increments *count.
53 bool MessageArg::has_value(int *count) const {
54 if (formattable == nullptr)
55 return false;
56
57 ++*count;
58 return true;
59 }
60
61 } // namespace internal
62
63 string16 MessageFormatter::FormatWithNumberedArgs(
64 StringPiece16 msg,
65 const internal::MessageArg& arg0,
66 const internal::MessageArg& arg1,
67 const internal::MessageArg& arg2,
68 const internal::MessageArg& arg3,
69 const internal::MessageArg& arg4,
70 const internal::MessageArg& arg5,
71 const internal::MessageArg& arg6) {
72 int32_t args_count = 0;
73 icu::Formattable args[] = {
74 arg0.has_value(&args_count) ? *arg0.formattable : icu::Formattable(),
75 arg1.has_value(&args_count) ? *arg1.formattable : icu::Formattable(),
76 arg2.has_value(&args_count) ? *arg2.formattable : icu::Formattable(),
77 arg3.has_value(&args_count) ? *arg3.formattable : icu::Formattable(),
78 arg4.has_value(&args_count) ? *arg4.formattable : icu::Formattable(),
79 arg5.has_value(&args_count) ? *arg5.formattable : icu::Formattable(),
80 arg6.has_value(&args_count) ? *arg6.formattable : icu::Formattable(),
81 };
82
83 UnicodeString msg_string(msg.data(), msg.size());
84 UErrorCode error = U_ZERO_ERROR;
85 icu::MessageFormat format(msg_string, error);
86 icu::UnicodeString formatted;
87 icu::FieldPosition ignore(icu::FieldPosition::DONT_CARE);
88 format.format(args, args_count, formatted, ignore, error);
89 if (U_FAILURE(error)) {
90 LOG(ERROR) << "MessageFormat(" << msg.as_string() << ") failed with "
91 << u_errorName(error);
92 return string16();
93 }
94 return string16(formatted.getBuffer(), formatted.length());
95 }
96
97 string16 MessageFormatter::FormatWithNamedArgs(
98 StringPiece16 msg,
99 StringPiece name0, const internal::MessageArg& arg0,
100 StringPiece name1, const internal::MessageArg& arg1,
101 StringPiece name2, const internal::MessageArg& arg2,
102 StringPiece name3, const internal::MessageArg& arg3,
103 StringPiece name4, const internal::MessageArg& arg4,
104 StringPiece name5, const internal::MessageArg& arg5,
105 StringPiece name6, const internal::MessageArg& arg6) {
106 icu::UnicodeString names[] = {
107 UnicodeStringFromStringPiece(name0),
108 UnicodeStringFromStringPiece(name1),
109 UnicodeStringFromStringPiece(name2),
110 UnicodeStringFromStringPiece(name3),
111 UnicodeStringFromStringPiece(name4),
112 UnicodeStringFromStringPiece(name5),
113 UnicodeStringFromStringPiece(name6),
114 };
115 int32_t args_count = 0;
116 icu::Formattable args[] = {
117 arg0.has_value(&args_count) ? *arg0.formattable : icu::Formattable(),
118 arg1.has_value(&args_count) ? *arg1.formattable : icu::Formattable(),
119 arg2.has_value(&args_count) ? *arg2.formattable : icu::Formattable(),
120 arg3.has_value(&args_count) ? *arg3.formattable : icu::Formattable(),
121 arg4.has_value(&args_count) ? *arg4.formattable : icu::Formattable(),
122 arg5.has_value(&args_count) ? *arg5.formattable : icu::Formattable(),
123 arg6.has_value(&args_count) ? *arg6.formattable : icu::Formattable(),
124 };
125
126 UnicodeString msg_string(msg.data(), msg.size());
127 UErrorCode error = U_ZERO_ERROR;
128 icu::MessageFormat format(msg_string, error);
129
130 icu::UnicodeString formatted;
131 format.format(names, args, args_count, formatted, error);
132 if (U_FAILURE(error)) {
133 LOG(ERROR) << "MessageFormat(" << msg.as_string() << ") failed with "
134 << u_errorName(error);
135 return string16();
136 }
137 return string16(formatted.getBuffer(), formatted.length());
138 }
139
140 } // namespace i18n
141 } // namespace base
OLDNEW
« no previous file with comments | « base/i18n/message_formatter.h ('k') | base/i18n/message_formatter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698