Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Side by Side Diff: base/base.gyp

Issue 1140153005: ICU msg format support with more than one arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 'includes': [ 9 'includes': [
10 '../build/win_precompile.gypi', 10 '../build/win_precompile.gypi',
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 }, { 280 }, {
281 'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC'], 281 'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC'],
282 }], 282 }],
283 ], 283 ],
284 }], 284 }],
285 ['OS == "ios"', { 285 ['OS == "ios"', {
286 'toolsets': ['host', 'target'], 286 'toolsets': ['host', 'target'],
287 }], 287 }],
288 ], 288 ],
289 'export_dependent_settings': [ 289 'export_dependent_settings': [
290 'base', 290 'base',
Ryan Sleevi 2015/07/31 22:19:36 This is where you should export the ICU headers -
jungshik at Google 2015/08/01 14:00:58 Thanks again. Done. Along with this, I tried dropp
Ryan Sleevi 2015/08/03 08:01:41 Right, because your unittest uses the ICU bits dir
291 ], 291 ],
292 'includes': [ 292 'includes': [
293 '../build/android/increase_size_for_speed.gypi', 293 '../build/android/increase_size_for_speed.gypi',
294 ], 294 ],
295 }, 295 },
296 { 296 {
297 'target_name': 'base_message_loop_tests', 297 'target_name': 'base_message_loop_tests',
298 'type': 'static_library', 298 'type': 'static_library',
299 'dependencies': [ 299 'dependencies': [
300 'base', 300 'base',
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 'files/memory_mapped_file_unittest.cc', 476 'files/memory_mapped_file_unittest.cc',
477 'files/scoped_temp_dir_unittest.cc', 477 'files/scoped_temp_dir_unittest.cc',
478 'gmock_unittest.cc', 478 'gmock_unittest.cc',
479 'guid_unittest.cc', 479 'guid_unittest.cc',
480 'hash_unittest.cc', 480 'hash_unittest.cc',
481 'i18n/break_iterator_unittest.cc', 481 'i18n/break_iterator_unittest.cc',
482 'i18n/case_conversion_unittest.cc', 482 'i18n/case_conversion_unittest.cc',
483 'i18n/char_iterator_unittest.cc', 483 'i18n/char_iterator_unittest.cc',
484 'i18n/file_util_icu_unittest.cc', 484 'i18n/file_util_icu_unittest.cc',
485 'i18n/icu_string_conversions_unittest.cc', 485 'i18n/icu_string_conversions_unittest.cc',
486 'i18n/message_formatter_unittest.cc',
486 'i18n/number_formatting_unittest.cc', 487 'i18n/number_formatting_unittest.cc',
487 'i18n/rtl_unittest.cc', 488 'i18n/rtl_unittest.cc',
488 'i18n/streaming_utf8_validator_unittest.cc', 489 'i18n/streaming_utf8_validator_unittest.cc',
489 'i18n/string_search_unittest.cc', 490 'i18n/string_search_unittest.cc',
490 'i18n/time_formatting_unittest.cc', 491 'i18n/time_formatting_unittest.cc',
491 'i18n/timezone_unittest.cc', 492 'i18n/timezone_unittest.cc',
492 'id_map_unittest.cc', 493 'id_map_unittest.cc',
493 'ios/crb_protocol_observers_unittest.mm', 494 'ios/crb_protocol_observers_unittest.mm',
494 'ios/device_util_unittest.mm', 495 'ios/device_util_unittest.mm',
495 'ios/weak_nsobject_unittest.mm', 496 'ios/weak_nsobject_unittest.mm',
(...skipping 1126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 '../build/isolate.gypi', 1623 '../build/isolate.gypi',
1623 ], 1624 ],
1624 'sources': [ 1625 'sources': [
1625 'base_unittests.isolate', 1626 'base_unittests.isolate',
1626 ], 1627 ],
1627 }, 1628 },
1628 ], 1629 ],
1629 }], 1630 }],
1630 ], 1631 ],
1631 } 1632 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698