Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1140133003: js-test.js: Allow creating a CompositorWorker. (Closed)

Created:
5 years, 7 months ago by sadrul
Modified:
5 years, 7 months ago
Reviewers:
kinuko
CC:
blink-reviews, tzik, nhiroki, dgrogan, cmumford, jsbell+idb_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

js-test.js: Allow creating a CompositorWorker. Change startWorker() in js-test.js to allow creating CompositorWorkers when passing 'compositor' as the second parameter. A SharedWorker is created for 'shared', and for any other value, a DedicatedWorker is created. BUG=436952 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195477

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Messages

Total messages: 8 (3 generated)
sadrul
Hi! I split this out of https://codereview.chromium.org/1101583003/ so this doesn't bit-rot. PTAL.
5 years, 7 months ago (2015-05-15 13:13:42 UTC) #2
kinuko
lgtm https://codereview.chromium.org/1140133003/diff/1/LayoutTests/resources/js-test.js File LayoutTests/resources/js-test.js (right): https://codereview.chromium.org/1140133003/diff/1/LayoutTests/resources/js-test.js#newcode817 LayoutTests/resources/js-test.js:817: var compositor = workerType == 'compositor'; nit: not ...
5 years, 7 months ago (2015-05-18 05:36:58 UTC) #3
sadrul
https://codereview.chromium.org/1140133003/diff/1/LayoutTests/resources/js-test.js File LayoutTests/resources/js-test.js (right): https://codereview.chromium.org/1140133003/diff/1/LayoutTests/resources/js-test.js#newcode817 LayoutTests/resources/js-test.js:817: var compositor = workerType == 'compositor'; On 2015/05/18 05:36:58, ...
5 years, 7 months ago (2015-05-18 18:07:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140133003/20001
5 years, 7 months ago (2015-05-18 18:07:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 21:03:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195477

Powered by Google App Engine
This is Rietveld 408576698