Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1140123002: Revert of Ensure the new navigation classifier works in the real world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index d34be5d18f4301301bc8516dcf4fe6d90cda8512..08555a3f9c5714cf6bfab46bbce3a8887d95cdc7 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -821,6 +821,7 @@
// Do navigation-type specific actions. These will make and commit an entry.
details->type = ClassifyNavigation(rfh, params);
+#if DCHECK_IS_ON()
// For site-per-process, both ClassifyNavigation methods get it wrong (see
// http://crbug.com/464014) so don't worry about a mismatch if that's the
// case.
@@ -832,9 +833,10 @@
// TODO(avi): Work this out.
if (details->type != NAVIGATION_TYPE_SAME_PAGE &&
new_type != NAVIGATION_TYPE_SAME_PAGE) {
- CHECK_EQ(details->type, new_type);
+ DCHECK_EQ(details->type, new_type);
}
}
+#endif // DCHECK_IS_ON()
// is_in_page must be computed before the entry gets committed.
details->is_in_page = AreURLsInPageNavigation(rfh->GetLastCommittedURL(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698