Issue 1140093004: Apply internal chrome_extensions.js review feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1140093004: Apply internal chrome_extensions.js review feedback. (Closed)

Created:
5 years, 7 months ago by Dan Beam

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, vitalyp+closure_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Apply internal chrome_extensions.js review feedback. TBR= BUG= Committed: https://chromium.googlesource.com/chromium/src/+/915be3ac68022aa3019bd4d79302fce41ad04b75

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/closure_compiler/externs/chrome_extensions.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/915be3ac68022aa3019bd4d79302fce41ad04b75 Cr-Commit-Position: refs/heads/master@{#329779}

5 years, 7 months ago (2015-05-14 01:48:32 UTC) #2

Dan Beam

5 years, 7 months ago (2015-05-14 01:48:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
915be3ac68022aa3019bd4d79302fce41ad04b75 (presubmit successful).

Expand Messages | Collapse Messages