Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1140083004: Change WebContents::last_active_time_ to Time instead of Timeticks. (Closed)

Created:
5 years, 7 months ago by Georges Khalil
Modified:
5 years, 7 months ago
Reviewers:
James Cook, jam
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, yurys, darin-cc_chromium.org, pfeldman, oshima+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, gab, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change WebContents::last_active_time_ to Time instead of Timeticks. For context, last_active_time_ is going to be used by session restore to order the loading of background tabs using MRU. In order for this to be robust, last_active_time_ must be saved and restore between sessions. Timeticks cannot be reliably restored as it's dependent on the current OS session. MRU code for session restore is being implemented in https://codereview.chromium.org/1131373003 Notes: - In dev tools, replaced "activity" with "active" for consistency - In OomPriorityManagerTest.Comparator, initialized last_active_time for all tabs, as this is necessary with Time (a default TimeTicks can go back in time, not the case with Time). BUG=472772 Committed: https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20 Cr-Commit-Position: refs/heads/master@{#330029}

Patch Set 1 : #

Messages

Total messages: 16 (9 generated)
Georges Khalil
jamescook@chromium.org: Please review changes in chrome/browser/chromeos/memory/* jam@chromium.org: Please review changes in rest.
5 years, 7 months ago (2015-05-14 16:43:45 UTC) #9
James Cook
lgtm
5 years, 7 months ago (2015-05-14 21:50:57 UTC) #10
jam
lgtm
5 years, 7 months ago (2015-05-14 22:22:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140083004/140001
5 years, 7 months ago (2015-05-15 02:57:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:140001)
5 years, 7 months ago (2015-05-15 03:01:59 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20 Cr-Commit-Position: refs/heads/master@{#330029}
5 years, 7 months ago (2015-05-15 03:02:52 UTC) #15
gab
5 years, 7 months ago (2015-05-20 18:41:51 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:140001) has been created in
https://codereview.chromium.org/1145233002/ by gab@chromium.org.

The reason for reverting is: Reverting for georgesak@ (his committer access
hasn't propagated yet it looks like).

After discussion with sky@, decided to keep TimeTicks..

Powered by Google App Engine
This is Rietveld 408576698