Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 1140063003: Add units to a histogram.xml label. (Closed)

Created:
5 years, 7 months ago by michaeln
Modified:
5 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add units to a histogram.xml label. Committed: https://crrev.com/bf4dbabe76d8f87054c402773f7abb8aaa329f56 Cr-Commit-Position: refs/heads/master@{#329794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
michaeln
ptal
5 years, 7 months ago (2015-05-14 02:28:07 UTC) #2
Ilya Sherman
LGTM, thanks.
5 years, 7 months ago (2015-05-14 02:30:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140063003/1
5 years, 7 months ago (2015-05-14 02:30:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 03:51:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 03:51:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf4dbabe76d8f87054c402773f7abb8aaa329f56
Cr-Commit-Position: refs/heads/master@{#329794}

Powered by Google App Engine
This is Rietveld 408576698