[Extensions] Fix crash in extension uninstall dialog

[Extensions] Fix crash in extension uninstall dialog

Refcount an extension so that it if it happens to be reloaded while the dialog
is showing, we don't crash.

BUG=487161
TBR=sky@chromium.org (small extension_uninstall_dialog_view.cc changes, reviewed by kalman)

Committed: https://crrev.com/9036764467c4addf722ac9fe58062b322bb56e15
Cr-Commit-Position: refs/heads/master@{#330143}

[Devlin, 2015-05-15 15:59:04]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[Devlin, 2015-05-15 15:59:04]

Quick fix to refcount that which is refcounted.

[not at google - send to devlin, 2015-05-15 16:09:38]

lgtm

https://codereview.chromium.org/1140053004/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

https://codereview.chromium.org/1140053004/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_uninstall_dialog.cc:52:
triggering_extension_(nullptr),
not necessary to initialise these anymore really

[Devlin, 2015-05-15 16:14:21]

https://codereview.chromium.org/1140053004/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

https://codereview.chromium.org/1140053004/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_uninstall_dialog.cc:52:
triggering_extension_(nullptr),
On 2015/05/15 16:09:38, kalman wrote:
> not necessary to initialise these anymore really

Could point.

[Devlin, 2015-05-15 16:14:34]

On 2015/05/15 16:14:21, Devlin wrote:
>
https://codereview.chromium.org/1140053004/diff/1/chrome/browser/extensions/e...
> File chrome/browser/extensions/extension_uninstall_dialog.cc (right):
> 
>
https://codereview.chromium.org/1140053004/diff/1/chrome/browser/extensions/e...
> chrome/browser/extensions/extension_uninstall_dialog.cc:52:
> triggering_extension_(nullptr),
> On 2015/05/15 16:09:38, kalman wrote:
> > not necessary to initialise these anymore really
> 
> Could point.

s/could/good.  Too early.

[Devlin, 2015-05-15 16:14:39]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-15 16:14:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1140053004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-05-15 16:16:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140053004/20001

[commit-bot: I haz the power, 2015-05-15 16:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 16:25:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2015-05-15 16:26:55]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-05-15 16:27:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140053004/20001

[commit-bot: I haz the power, 2015-05-15 16:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 16:55:21]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Devlin, 2015-05-15 17:47:15]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-15 17:47:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1140053004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-05-15 17:48:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140053004/40001

[commit-bot: I haz the power, 2015-05-15 18:34:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-15 18:37:06]

Patchset 3 (id:??) landed as
https://crrev.com/9036764467c4addf722ac9fe58062b322bb56e15
Cr-Commit-Position: refs/heads/master@{#330143}