Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: components/safe_json_parser/safe_json_parser.cc

Issue 1140053003: Refactoring: Moving the SafeJsonParser to its own component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Catching up with WebstoreInstallHelper changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_json_parser/safe_json_parser.cc
diff --git a/chrome/browser/safe_json_parser.cc b/components/safe_json_parser/safe_json_parser.cc
similarity index 74%
rename from chrome/browser/safe_json_parser.cc
rename to components/safe_json_parser/safe_json_parser.cc
index 232fdd43daed61c90439de21ebb0189410a61660..0ad94c5bfe94a2bbb59726f260fad87e907a7b44 100644
--- a/chrome/browser/safe_json_parser.cc
+++ b/components/safe_json_parser/safe_json_parser.cc
@@ -2,41 +2,50 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/safe_json_parser.h"
+#include "components/safe_json_parser/safe_json_parser.h"
-#include "chrome/common/chrome_utility_messages.h"
-#include "chrome/grit/generated_resources.h"
+#include <string>
+
+#include "base/strings/utf_string_conversions.h"
+#include "base/tuple.h"
+#include "base/values.h"
+#include "components/safe_json_parser/safe_json_parser_messages.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/utility_process_host.h"
+#include "grit/components_strings.h"
+#include "ipc/ipc_message_macros.h"
#include "ui/base/l10n/l10n_util.h"
using content::BrowserThread;
using content::UtilityProcessHost;
+namespace safe_json_parser {
+
SafeJsonParser::SafeJsonParser(const std::string& unsafe_json,
const SuccessCallback& success_callback,
const ErrorCallback& error_callback)
: unsafe_json_(unsafe_json),
success_callback_(success_callback),
- error_callback_(error_callback) {}
+ error_callback_(error_callback) {
+}
void SafeJsonParser::Start() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
+ BrowserThread::IO, FROM_HERE,
base::Bind(&SafeJsonParser::StartWorkOnIOThread, this));
}
-SafeJsonParser::~SafeJsonParser() {}
+SafeJsonParser::~SafeJsonParser() {
+}
void SafeJsonParser::StartWorkOnIOThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
UtilityProcessHost* host =
UtilityProcessHost::Create(this, base::MessageLoopProxy::current().get());
- host->SetName(l10n_util::GetStringUTF16(
- IDS_UTILITY_PROCESS_JSON_PARSER_NAME));
- host->Send(new ChromeUtilityMsg_ParseJSON(unsafe_json_));
+ host->SetName(
+ l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_JSON_PARSER_NAME));
+ host->Send(new SafeJsonParserMsg_ParseJSON(unsafe_json_));
}
void SafeJsonParser::OnJSONParseSucceeded(const base::ListValue& wrapper) {
@@ -58,8 +67,7 @@ void SafeJsonParser::ReportResults() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
+ BrowserThread::UI, FROM_HERE,
base::Bind(&SafeJsonParser::ReportResultOnUIThread, this));
}
@@ -77,11 +85,13 @@ void SafeJsonParser::ReportResultOnUIThread() {
bool SafeJsonParser::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(SafeJsonParser, message)
- IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseJSON_Succeeded,
+ IPC_MESSAGE_HANDLER(SafeJsonParserHostMsg_ParseJSON_Succeeded,
OnJSONParseSucceeded)
- IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseJSON_Failed,
+ IPC_MESSAGE_HANDLER(SafeJsonParserHostMsg_ParseJSON_Failed,
OnJSONParseFailed)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
}
+
+} // namespace safe_json_parser
« no previous file with comments | « components/safe_json_parser/safe_json_parser.h ('k') | components/safe_json_parser/safe_json_parser_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698