chrome/browser/extensions/webstore_install_helper.cc - Issue 1140053003: Refactoring: Moving the SafeJsonParser to its own component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_install_helper.cc

Issue 1140053003: Refactoring: Moving the SafeJsonParser to its own component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Catching up with WebstoreInstallHelper changes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/webstore_install_helper.cc

diff --git a/chrome/browser/extensions/webstore_install_helper.cc b/chrome/browser/extensions/webstore_install_helper.cc

index 3f708f6dcb8830c9a810d35ae217abe4d2a0b08a..b487bf65bc16986486228b8b890bec5964305b3d 100644

--- a/chrome/browser/extensions/webstore_install_helper.cc

+++ b/chrome/browser/extensions/webstore_install_helper.cc

@@ -7,7 +7,7 @@

#include "base/bind.h"

#include "base/values.h"

#include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"

-#include "chrome/browser/safe_json_parser.h"

+#include "components/safe_json_parser/safe_json_parser.h"

#include "content/public/browser/browser_thread.h"

#include "net/base/load_flags.h"

#include "net/url_request/url_request.h"

@@ -49,7 +49,7 @@ void WebstoreInstallHelper::Start() {

// Use base::Unretained so that base::Bind won't AddRef() on us. Otherwise,

// we'll have two callbacks holding references to us, only one of which will

// ever be called.

- json_parser_ = new SafeJsonParser(

+ json_parser_ = new safe_json_parser::SafeJsonParser(

manifest_,

base::Bind(&WebstoreInstallHelper::OnJSONParseSucceeded,

base::Unretained(this)),

« no previous file with comments | « chrome/browser/extensions/webstore_install_helper.h ('k') | chrome/browser/safe_json_parser.h » ('j') | no next file with comments »