Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: components/safe_json_parser/safe_json_parser.h

Issue 1140053003: Refactoring: Moving the SafeJsonParser to its own component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing export macro, duplicate android string Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SAFE_JSON_PARSER_H_ 5 #ifndef COMPONENTS_SAFE_JSON_PARSER_SAFE_JSON_PARSER_H_
6 #define CHROME_BROWSER_SAFE_JSON_PARSER_H_ 6 #define COMPONENTS_SAFE_JSON_PARSER_SAFE_JSON_PARSER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "content/public/browser/utility_process_host_client.h" 13 #include "content/public/browser/utility_process_host_client.h"
14 14
15 namespace base { 15 namespace base {
16 class ListValue; 16 class ListValue;
17 class Value; 17 class Value;
18 } 18 }
19 19
20 namespace IPC { 20 namespace IPC {
21 class Message; 21 class Message;
22 } 22 }
23 23
24 namespace safe_json_parser {
25
24 // SafeJsonParser parses a given JSON safely via a utility process. The object 26 // SafeJsonParser parses a given JSON safely via a utility process. The object
25 // is ref-counted and kept alive after Start() is called until one of the two 27 // is ref-counted and kept alive after Start() is called until one of the two
26 // callbacks is called. 28 // callbacks is called.
27 class SafeJsonParser : public content::UtilityProcessHostClient { 29 class SafeJsonParser
30 : public content::UtilityProcessHostClient {
Robert Sesek 2015/06/01 20:25:48 nit: why this break? this is fewer than 80 cols
Eran Messeri 2015/06/02 10:31:42 No reason, fixed.
28 public: 31 public:
29 typedef base::Callback<void(scoped_ptr<base::Value>)> SuccessCallback; 32 typedef base::Callback<void(scoped_ptr<base::Value>)> SuccessCallback;
30 typedef base::Callback<void(const std::string&)> ErrorCallback; 33 typedef base::Callback<void(const std::string&)> ErrorCallback;
31 34
32 SafeJsonParser(const std::string& unsafe_json, 35 SafeJsonParser(const std::string& unsafe_json,
33 const SuccessCallback& success_callback, 36 const SuccessCallback& success_callback,
34 const ErrorCallback& error_callback); 37 const ErrorCallback& error_callback);
35 38
36 void Start(); 39 void Start();
37 40
(...skipping 14 matching lines...) Expand all
52 const std::string unsafe_json_; 55 const std::string unsafe_json_;
53 SuccessCallback success_callback_; 56 SuccessCallback success_callback_;
54 ErrorCallback error_callback_; 57 ErrorCallback error_callback_;
55 58
56 scoped_ptr<base::Value> parsed_json_; 59 scoped_ptr<base::Value> parsed_json_;
57 std::string error_; 60 std::string error_;
58 61
59 DISALLOW_COPY_AND_ASSIGN(SafeJsonParser); 62 DISALLOW_COPY_AND_ASSIGN(SafeJsonParser);
60 }; 63 };
61 64
62 #endif // CHROME_BROWSER_SAFE_JSON_PARSER_H_ 65 } // namespace safe_json_parser
66
67 #endif // COMPONENTS_SAFE_JSON_PARSER_SAFE_JSON_PARSER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698