components/safe_json_parser/BUILD.gn - Issue 1140053003: Refactoring: Moving the SafeJsonParser to its own component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_json_parser/BUILD.gn

Issue 1140053003: Refactoring: Moving the SafeJsonParser to its own component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Localized string, build fixes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/strings/android_chrome_strings.grd ('K') | « components/safe_json_parser.gypi ('k') | components/safe_json_parser/DEPS » ('j') | components/safe_json_parser/safe_json_parser.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # GYP version: components/safe_json_parser.gypi:safe_json_parser

	6 static_library("safe_json_parser") {

	7 sources = [

	8 "safe_json_parser.cc",

	9 "safe_json_parser.h",

	10 "safe_json_parser_export.h",

	11 "safe_json_parser_message_filter.cc",

	12 "safe_json_parser_message_filter.h",

	13 "safe_json_parser_messages.cc",

	14 "safe_json_parser_messages.h",

	15 ]

	16
	Robert Sesek 2015/05/26 19:39:27 Does this need to define SAFE_JSON_PARSER_IMPLEMEN Does this need to define SAFE_JSON_PARSER_IMPLEMENTATION? Eran Messeri 2015/05/28 13:54:27 Yes, done. I reworked the BUILD.gn and safe_json_p Show quoted text On 2015/05/26 19:39:27, Robert Sesek wrote: > Does this need to define SAFE_JSON_PARSER_IMPLEMENTATION? Yes, done. I reworked the BUILD.gn and safe_json_parser.gypi files a bit to provide separate targets for the safe_json_parser_message_filter and the safe_json_parser.
	17 deps = [

	18 "//base",

	19 "//components/strings",

	20 "//content/public/browser",

	21 "//ipc",

	22 "//ui/base",

	23 ]

	24 }

OLD	NEW