Refactoring: Moving the SafeJsonParser to its own component.

components/safe_json_parser/safe_json_parser.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/safe_json_parser.h"
+#include "components/safe_json_parser/safe_json_parser.h"
 
-#include "chrome/common/chrome_utility_messages.h"
-#include "chrome/grit/generated_resources.h"
+#include <string>
+
+#include "base/strings/utf_string_conversions.h"
+#include "base/tuple.h"
+#include "base/values.h"
+#include "ipc/ipc_message_macros.h"

[jam, 2015/05/18 23:59:19]

nit: this is an internal file, you shouldn't have to include it (i.e. a
_messages.h file is enough)

[Eran Messeri, 2015/05/19 20:49:56]

Done.

+#include "components/safe_json_parser/safe_json_parser_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/utility_process_host.h"
-#include "ui/base/l10n/l10n_util.h"
 
 using content::BrowserThread;
 using content::UtilityProcessHost;
 
+namespace {
+
+const char* kJSONParserProcessName = "JSON Parser";
+
+}  // namespace
+
+namespace safe_json_parser {
+
 SafeJsonParser::SafeJsonParser(const std::string& unsafe_json,
                                const SuccessCallback& success_callback,
                                const ErrorCallback& error_callback)
     : unsafe_json_(unsafe_json),
       success_callback_(success_callback),
-      error_callback_(error_callback) {}
+      error_callback_(error_callback) {
+}
 
 void SafeJsonParser::Start() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   BrowserThread::PostTask(
-      BrowserThread::IO,
-      FROM_HERE,
+      BrowserThread::IO, FROM_HERE,
       base::Bind(&SafeJsonParser::StartWorkOnIOThread, this));
 }
 
-SafeJsonParser::~SafeJsonParser() {}
+SafeJsonParser::~SafeJsonParser() {
+}
 
 void SafeJsonParser::StartWorkOnIOThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   UtilityProcessHost* host =
       UtilityProcessHost::Create(this, base::MessageLoopProxy::current().get());
-  host->SetName(l10n_util::GetStringUTF16(
-      IDS_UTILITY_PROCESS_JSON_PARSER_NAME));
-  host->Send(new ChromeUtilityMsg_ParseJSON(unsafe_json_));
+  host->SetName(base::ASCIIToUTF16(kJSONParserProcessName));

[jam, 2015/05/18 23:59:19]

seems like a regression here that you switch from translated to english name

[Eran Messeri, 2015/05/19 20:49:56]

Correct.
It does not seem to be trivial to get internatiolanized strings under
//components and ultimately this string is just used for a process name.
I argue that users savvy enough to dig into the list of processes running in
their browser would be OK with a non-internationalized name (but then again,
supporting non-latin characters in filenames was a rudimentary feature when I
started using computers...).
However if you can suggest an easy way to internationalize this string I'd be
happy to do it.

[jam, 2015/05/20 15:38:31]

Everywhere else that sets process names in the task manager appears to use a
localized string, so we should be consistent (otherwise the product looks
unpolished).

https://code.google.com/p/chromium/codesearch#search/&q=file:src/components%2...
shows examples of other components using translated strings.

[Eran Messeri, 2015/05/26 16:19:59]

Done - added the localized string back as suggested.

+  host->Send(new SafeJsonParserMsg_ParseJSON(unsafe_json_));
 }
 
 void SafeJsonParser::OnJSONParseSucceeded(const base::ListValue& wrapper) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   const base::Value* value = NULL;
   CHECK(wrapper.Get(0, &value));
 
   parsed_json_.reset(value->DeepCopy());
   ReportResults();
 }
 
 void SafeJsonParser::OnJSONParseFailed(const std::string& error_message) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   error_ = error_message;
   ReportResults();
 }
 
 void SafeJsonParser::ReportResults() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   BrowserThread::PostTask(
-      BrowserThread::UI,
-      FROM_HERE,
+      BrowserThread::UI, FROM_HERE,
       base::Bind(&SafeJsonParser::ReportResultOnUIThread, this));
 }
 
 void SafeJsonParser::ReportResultOnUIThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (error_.empty() && parsed_json_) {
     if (!success_callback_.is_null())
       success_callback_.Run(parsed_json_.Pass());
   } else {
     if (!error_callback_.is_null())
       error_callback_.Run(error_);
   }
 }
 
 bool SafeJsonParser::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(SafeJsonParser, message)
-    IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseJSON_Succeeded,
-                        OnJSONParseSucceeded)
-    IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseJSON_Failed,
-                        OnJSONParseFailed)
-    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_MESSAGE_HANDLER(SafeJsonParserHostMsg_ParseJSON_Succeeded,
+                      OnJSONParseSucceeded)
+  IPC_MESSAGE_HANDLER(SafeJsonParserHostMsg_ParseJSON_Failed, OnJSONParseFailed)
+  IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
+
+}  // namespace safe_json_parser