Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1140053002: Migrate error messages, part 11. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 11. R=mvstanton@chromium.org Committed: https://crrev.com/f3f0b2724b20ab0af4da67235145f26046231354 Cr-Commit-Position: refs/heads/master@{#28423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -160 lines) Patch
M src/api.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/factory.h View 2 chunks +5 lines, -14 lines 0 comments Download
M src/factory.cc View 3 chunks +7 lines, -51 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/json-parser.h View 2 chunks +8 lines, -14 lines 0 comments Download
M src/jsregexp.cc View 7 chunks +15 lines, -34 lines 0 comments Download
M src/messages.h View 5 chunks +12 lines, -0 lines 0 comments Download
M src/messages.js View 3 chunks +0 lines, -7 lines 0 comments Download
M src/pending-compilation-error-handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/symbol.js View 1 chunk +1 line, -1 line 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -6 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +33 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 7 months ago (2015-05-13 12:53:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140053002/1
5 years, 7 months ago (2015-05-15 12:37:02 UTC) #3
mvstanton
lgtm
5 years, 7 months ago (2015-05-15 12:44:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 13:10:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140053002/1
5 years, 7 months ago (2015-05-15 13:30:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 13:32:38 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 13:32:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f0b2724b20ab0af4da67235145f26046231354
Cr-Commit-Position: refs/heads/master@{#28423}

Powered by Google App Engine
This is Rietveld 408576698