fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp - Issue 1140033004: Merge V8 API updates to xfa branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp

Issue 1140033004: Merge V8 API updates to xfa branch (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp

diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp

index 94164f12b853b76a88238df7cccc3c6ee9a0f6bd..e8bd9d0b7efedba1c4df9b301925c3aff9c11de6 100644

--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp

+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp

@@ -134,7 +134,7 @@ FX_BOOL CPDFXFA_App::RemoveFormFillEnv(CPDFDoc_Environment* pEnv)

}

void CPDFXFA_App::ReleaseRuntime()

{

- v8::Persistent<v8::Context> context;

+ v8::Global<v8::Context> context;

JS_ReleaseRuntime((IJS_Runtime*)m_hJSERuntime, context);

}

« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »