Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2346)

Unified Diff: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

Issue 114003006: Print less output from compare_videos.py in WebRTC quality test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
index b5ffbc841ea077b7cae1f44b1cf8957d21584509..227de2e40c2dc179e556790888e6c5936fd2b7a6 100644
--- a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
@@ -283,9 +283,20 @@ class WebrtcVideoQualityBrowserTest : public WebRtcTestBase {
VLOG(0) << "Running " << compare_command.GetCommandLineString();
std::string output;
bool ok = base::GetAppOutput(compare_command, &output);
+
+ size_t first_result_line_pos = output.find("RESULT");
+ if (first_result_line_pos == std::string::npos) {
+ LOG(ERROR) << "Got unexpected output from compare_videos.py:"
+ << output;
+ return false;
+ }
+
// Print to stdout to ensure the perf numbers are parsed properly by the
- // buildbot step.
- printf("Output was:\n\n%s\n", output.c_str());
+ // buildbot step. Only print the result lines to ensure we write all of
+ // it before we hit some os buffer limit and give other processes the
+ // chance to write to Chrome's stdout.
+ std::string result_lines = output.substr(first_result_line_pos);
+ printf("Output was:\n\n%s\n", result_lines.c_str());
return ok;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698