Issue 114003005: Add Download.ShowDangerousDownloadConfirmationPrompt for Windows/CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114003005: Add Download.ShowDangerousDownloadConfirmationPrompt for Windows/CrOS (Closed)

Created:
6 years, 11 months ago by felt

Modified:
6 years, 11 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, asanka, tfarina, benjhayden+dwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add Download.ShowDangerousDownloadConfirmationPrompt for Windows/CrOS The Download.ShowDangerousDownloadConfirmationPrompt UMA stat tells us how often people go through the last step of recovering a malicious binary from chrome://downloads. This UMA stat was added for GTK, but was missing for Win/CrOS. This CL adds it to the Views (Win/CrOS) version of the dialog. BUG=331603 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243172

Patch Set 1 #

Patch Set 2 : Typo #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/download/download_danger_prompt_views.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/114003005/60001

6 years, 11 months ago (2014-01-04 18:30:03 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241683

6 years, 11 months ago (2014-01-04 21:28:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/114003005/60001

6 years, 11 months ago (2014-01-06 19:41:13 UTC) #5

Message was sent while issue was closed.

Change committed as 243172

Expand Messages | Collapse Messages