content/browser/dom_storage/dom_storage_namespace.cc - Issue 1140013003: Adjust LocalStorage commit rate limiting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/dom_storage/dom_storage_namespace.cc

Issue 1140013003: Adjust LocalStorage commit rate limiting. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/dom_storage/dom_storage_namespace.cc

diff --git a/content/browser/dom_storage/dom_storage_namespace.cc b/content/browser/dom_storage/dom_storage_namespace.cc

index f554ac58814260442a14cdf3bd90b140ba786511..b4c9fc5243f2a7db299745e230b7b21301d8a4f1 100644

--- a/content/browser/dom_storage/dom_storage_namespace.cc

+++ b/content/browser/dom_storage/dom_storage_namespace.cc

@@ -59,7 +59,8 @@ void DOMStorageNamespace::CloseStorageArea(DOMStorageArea* area) {

AreaHolder* holder = GetAreaHolder(area->origin());

DCHECK(holder);

DCHECK_EQ(holder->area_.get(), area);

- --(holder->open_count_);

+ if (!--(holder->open_count_) && holder->area_->HasUncommittedChanges())

+ holder->area_->ScheduleImmediateCommit();

// TODO(michaeln): Clean up areas that aren't needed in memory anymore.

// The in-process-webkit based impl didn't do this either, but would be nice.

}