Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1140003003: Add mocha to third_party (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 6 months ago
Reviewers:
Daniel Berlin, stevenjb, *cpu_(ooo_6.6-7.5), open-source-third-party-reviews, security, *James Hawkins
CC:
chromium-reviews, apacible
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mocha to third_party Mocha is a test framework that makes asynchronous tests simple and helps batch multiple logical tests into a single browser test. This makes writing a web component test framework much, much easier. See http://crrev.com/1124873002 for an example of how mocha could be used to write a simple in-browser test of a custom element. BUG=492889 Committed: https://crrev.com/b357fe4797916cb7983327e21ac9995f63b28816 Cr-Commit-Position: refs/heads/master@{#331880}

Patch Set 1 #

Patch Set 2 : github url #

Patch Set 3 : set owner to just me, pending #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6598 lines, -8 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/mocha/LICENSE View 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/mocha/OWNERS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A third_party/mocha/README.chromium View 1 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/mocha/README.md View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/mocha/mocha.js View 1 chunk +6564 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
michaelpg
This will enable relatively simple testing of Polymer elements in Chromium.
5 years, 7 months ago (2015-05-14 03:48:55 UTC) #2
michaelpg
PTAL.
5 years, 7 months ago (2015-05-19 01:23:02 UTC) #5
Daniel Berlin
LGTM for OSTPR
5 years, 7 months ago (2015-05-19 15:52:38 UTC) #8
James Hawkins
lgtm
5 years, 7 months ago (2015-05-19 16:07:28 UTC) #9
jschuh
Please send an email to security@chromium.org describing the use and how it will be exposed ...
5 years, 7 months ago (2015-05-19 16:47:28 UTC) #10
michaelpg
On 2015/05/19 16:47:28, jschuh wrote: > Please send an email to mailto:security@chromium.org describing the use ...
5 years, 7 months ago (2015-05-20 00:26:29 UTC) #11
michaelpg
Updated bug to point to https://code.google.com/p/chromium/issues/detail?id=492889
5 years, 7 months ago (2015-05-27 23:14:57 UTC) #14
cpu_(ooo_6.6-7.5)
lgtm
5 years, 6 months ago (2015-05-28 19:45:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140003003/60001
5 years, 6 months ago (2015-05-28 22:23:53 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-05-28 23:36:06 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 23:37:59 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b357fe4797916cb7983327e21ac9995f63b28816
Cr-Commit-Position: refs/heads/master@{#331880}

Powered by Google App Engine
This is Rietveld 408576698