Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139993003: Tidy public fpdfview.h and fpdf_flatten.h. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tidy public fpdfview.h and fpdf_flatten.h. Mostly cosmetic; fix a spelling error, make comment style consistent, remove unnecessary #ifdefs, remove unused globals. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3a251306b0fc80eadbd49a806b27c31e285c3223

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 6

Patch Set 3 : Remove "noting" everywhere, better comment block. #

Patch Set 4 : else after return #

Patch Set 5 : Readability. #

Total comments: 2

Patch Set 6 : Reduce indentation even more, fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -89 lines) Patch
M fpdfsdk/src/fpdf_flatten.cpp View 1 2 3 4 5 2 chunks +41 lines, -49 lines 0 comments Download
M public/fpdf_flatten.h View 1 2 1 chunk +17 lines, -18 lines 0 comments Download
M public/fpdfview.h View 1 2 7 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Tom Sepez
For review.
5 years, 7 months ago (2015-05-19 18:13:47 UTC) #2
Lei Zhang
https://codereview.chromium.org/1139993003/diff/20001/public/fpdf_flatten.h File public/fpdf_flatten.h (right): https://codereview.chromium.org/1139993003/diff/20001/public/fpdf_flatten.h#newcode18 public/fpdf_flatten.h:18: #define FLATTEN_NOTINGTODO FLATTEN_NOTHINGTODO // [sic]. We should fix the ...
5 years, 7 months ago (2015-05-19 19:11:30 UTC) #3
Tom Sepez
https://codereview.chromium.org/1139993003/diff/20001/public/fpdf_flatten.h File public/fpdf_flatten.h (right): https://codereview.chromium.org/1139993003/diff/20001/public/fpdf_flatten.h#newcode18 public/fpdf_flatten.h:18: #define FLATTEN_NOTINGTODO FLATTEN_NOTHINGTODO // [sic]. On 2015/05/19 19:11:29, Lei ...
5 years, 7 months ago (2015-05-19 19:40:01 UTC) #4
Tom Sepez
See PS #5.
5 years, 7 months ago (2015-05-19 19:47:15 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/1139993003/diff/70001/fpdfsdk/src/fpdf_flatten.cpp File fpdfsdk/src/fpdf_flatten.cpp (right): https://codereview.chromium.org/1139993003/diff/70001/fpdfsdk/src/fpdf_flatten.cpp#newcode130 fpdfsdk/src/fpdf_flatten.cpp:130: return FLATTEN_NOTHINGTODO; Can we just do: if (!pAnnots) ...
5 years, 7 months ago (2015-05-19 20:20:38 UTC) #6
Tom Sepez
Lei, please sanity check the change. Thanks. https://codereview.chromium.org/1139993003/diff/70001/fpdfsdk/src/fpdf_flatten.cpp File fpdfsdk/src/fpdf_flatten.cpp (right): https://codereview.chromium.org/1139993003/diff/70001/fpdfsdk/src/fpdf_flatten.cpp#newcode130 fpdfsdk/src/fpdf_flatten.cpp:130: return FLATTEN_NOTHINGTODO; ...
5 years, 7 months ago (2015-05-19 21:36:39 UTC) #7
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-19 21:42:55 UTC) #8
Tom Sepez
5 years, 7 months ago (2015-05-20 17:00:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) manually as
3a251306b0fc80eadbd49a806b27c31e285c3223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698