Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 1139983002: Speculative fix for WebPluginContainerImpl::calculateGeometry nullptr crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPluginContainerImpl.cpp
diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp
index 4f1a15dcd47535e662d8e6aae5ab679d8a4dc776..c713f117dedb88e2ecf976fe88345916ed40cbac 100644
--- a/Source/web/WebPluginContainerImpl.cpp
+++ b/Source/web/WebPluginContainerImpl.cpp
@@ -417,7 +417,7 @@ void WebPluginContainerImpl::scrollRect(const WebRect& rect)
void WebPluginContainerImpl::reportGeometry()
{
// We cannot compute geometry without a parent or layoutObject.
- if (!parent() || !m_element->layoutObject())
+ if (!parent() || !m_element || !m_element->layoutObject())
return;
IntRect windowRect, clipRect, unobscuredRect;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698