Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 1139973005: Fix gyp failure on linux when use_ozone=1 is set (Closed)

Created:
5 years, 7 months ago by babu
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, garykac
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gyp failure on linux when use_ozone=1 is set BUG=489264 TEST=build/gyp_chromium -Duse_ozone=1 Committed: https://crrev.com/84251bbd423965f9db89331761185b5630147215 Cr-Commit-Position: refs/heads/master@{#330701}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
https://codereview.chromium.org/1139973005/diff/1/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1139973005/diff/1/build/gn_migration.gypi#newcode243 build/gn_migration.gypi:243: ['remoting==1 and chromeos==0 and use_x11==1', { This seems to ...
5 years, 7 months ago (2015-05-18 20:44:16 UTC) #3
babu
https://codereview.chromium.org/1139973005/diff/1/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1139973005/diff/1/build/gn_migration.gypi#newcode243 build/gn_migration.gypi:243: ['remoting==1 and chromeos==0 and use_x11==1', { On 2015/05/18 20:44:16, ...
5 years, 7 months ago (2015-05-19 11:10:53 UTC) #4
Dirk Pranke
https://codereview.chromium.org/1139973005/diff/1/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1139973005/diff/1/build/gn_migration.gypi#newcode243 build/gn_migration.gypi:243: ['remoting==1 and chromeos==0 and use_x11==1', { Oh, I'm sorry, ...
5 years, 7 months ago (2015-05-19 19:54:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139973005/1
5 years, 7 months ago (2015-05-20 04:09:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 05:07:32 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 05:08:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84251bbd423965f9db89331761185b5630147215
Cr-Commit-Position: refs/heads/master@{#330701}

Powered by Google App Engine
This is Rietveld 408576698