Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1139973003: Fix gradual deterioration of cadence based rendering. (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gradual deterioration of cadence based rendering. When a cadence based rendering sequence exceeds drift, we should not count the over-rendered frame against the next in sequence. Doing so causes an accumulation of errors. Also extends the moving average for durations to 32 values and the allowable drift to 16.66ms to stabilize the Catzilla 60fps and Elite: Dangerous 60fps clips, which were hitting hysteresis very frequently. BUG=439548 TEST=new unittest. Committed: https://crrev.com/f0ecec8eb2f9a1b8937d918f233b663ffc26bc01 Cr-Commit-Position: refs/heads/master@{#329987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -22 lines) Patch
M media/filters/video_renderer_algorithm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/video_renderer_algorithm.cc View 8 chunks +24 lines, -21 lines 0 comments Download
M media/filters/video_renderer_algorithm_unittest.cc View 2 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
Polishes the experience for 60fps clips and fixes a bug with cadence based rendering.
5 years, 7 months ago (2015-05-14 22:30:30 UTC) #2
xhwang
lgtm
5 years, 7 months ago (2015-05-14 23:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139973003/1
5 years, 7 months ago (2015-05-14 23:07:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 00:11:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:12:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0ecec8eb2f9a1b8937d918f233b663ffc26bc01
Cr-Commit-Position: refs/heads/master@{#329987}

Powered by Google App Engine
This is Rietveld 408576698