Issue 1139973002: Make mojo_shell_child not crash when done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1139973002: Make mojo_shell_child not crash when done (Closed)

Created:
5 years, 7 months ago by sky

Modified:
5 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make mojo_shell_child not crash when done This is https://codereview.chromium.org/1082973004 ported to chrome. BUG=none TEST=none R=viettrungluu@chromium.org Committed: https://crrev.com/bb9ef4cedfbe690c745fc786535984eb784aec8c Cr-Commit-Position: refs/heads/master@{#329513}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	mojo/runner/child_process.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139973002/1

5 years, 7 months ago (2015-05-12 22:10:55 UTC) #3

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 22:27:24 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bb9ef4cedfbe690c745fc786535984eb784aec8c
Cr-Commit-Position: refs/heads/master@{#329513}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages