[Download Notification] Add tests of incognito download

[Download Notification] Add tests of incognito download

BUG=480489
TEST=run newly added tests

Committed: https://crrev.com/c42c4385549232d293c8aa7bb4b7248af6aafba0
Cr-Commit-Position: refs/heads/master@{#329695}

[yoshiki, 2015-05-13 08:22:08]

yoshiki@chromium.org changed reviewers:
+ asanka@chromium.org

[yoshiki, 2015-05-13 08:22:28]

Asanka, PTAL. Thanks.

[asanka, 2015-05-13 15:10:30]

lgtm

https://codereview.chromium.org/1139963004/diff/1/chrome/browser/download/not...
File chrome/browser/download/notification/download_notification_browsertest.cc
(right):

https://codereview.chromium.org/1139963004/diff/1/chrome/browser/download/not...
chrome/browser/download/notification/download_notification_browsertest.cc:590:
download_change_notification_observer.Wait();
Remind me again why we aren't using something like DownloadTestObserverTerminal?

[yoshiki, 2015-05-13 17:03:04]

https://codereview.chromium.org/1139963004/diff/1/chrome/browser/download/not...
File chrome/browser/download/notification/download_notification_browsertest.cc
(right):

https://codereview.chromium.org/1139963004/diff/1/chrome/browser/download/not...
chrome/browser/download/notification/download_notification_browsertest.cc:590:
download_change_notification_observer.Wait();
On 2015/05/13 15:10:30, asanka wrote:
> Remind me again why we aren't using something like
DownloadTestObserverTerminal?

I thought we can write it with DownloadTestObserverTerminal as following:
  1 DownloadTestObserverTerminal download_observer;
  2 NotificationUpdateObserver notification_change_observer;
  3 /* Request to complete the download here. */
  4 download_observer.WaitForFinished();
  5 notification_change_observer.Wait();
  6 /* further checks */

But it has a timing issue. The update of the notification progress (eg. 80% ->
90%) may be occurred between the installation of observer (line #2) and download
completion (initiated in line #3). As result, the notification change after
completion (eg. 90% -> completed) can't be waited for in line #5, and the test
may proceed to line #6 without notification change. This is a problem and causes
flakiness.

[yoshiki, 2015-05-13 17:03:09]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-05-13 17:03:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139963004/1

[yoshiki, 2015-05-13 17:14:49]

The CQ bit was unchecked by yoshiki@chromium.org

[yoshiki, 2015-05-13 17:16:02]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-05-13 17:16:02]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/1139963004/#ps20001
(title: "fix build failure")

[commit-bot: I haz the power, 2015-05-13 17:16:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139963004/20001

[yoshiki, 2015-05-13 18:34:31]

The CQ bit was unchecked by yoshiki@chromium.org

[yoshiki, 2015-05-13 18:39:17]

Patchset #2 (id:20001) has been deleted

[yoshiki, 2015-05-13 18:39:31]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-05-13 18:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/1139963004/#ps40001
(title: "fix build failure and test failure on debug build")

[commit-bot: I haz the power, 2015-05-13 18:41:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139963004/40001

[commit-bot: I haz the power, 2015-05-13 19:15:13]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-05-13 19:15:55]

Patchset 2 (id:??) landed as
https://crrev.com/c42c4385549232d293c8aa7bb4b7248af6aafba0
Cr-Commit-Position: refs/heads/master@{#329695}