Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1139963003:
Move linux_arm_compile from 100% CQ experiment to full CQ member (Closed)
|
Created:
5 years, 7 months ago by Sam Clegg Modified:
5 years, 6 months ago Reviewers:
Paweł Hajdan Jr. CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove linux_arm_compile from 100% CQ experiment to full CQ member
BUG=384104
Committed: https://crrev.com/a2caf9a3a0cb9d0f79c028af3aa7122e90912a7d
Cr-Commit-Position: refs/heads/master@{#333738}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : rebase #Messages
Total messages: 22 (4 generated)
sbc@chromium.org changed reviewers: + phajdan.jr@chromium.org
Probably needs to get figure out this issue first: https://code.google.com/p/chromium/issues/detail?id=485833
Please get https://code.google.com/p/chromium/issues/detail?id=485833 fixed before proceeding with this review.
On 2015/05/13 16:02:23, Paweł Hajdan Jr. wrote: > Please get https://code.google.com/p/chromium/issues/detail?id=485833 fixed > before proceeding with this review. Done. PTAL
What's going on with failures to compile without patch at http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... , e.g. http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... ? I'd also like to see a CL to move corresponding bot to main waterfall from FYI, and then the changes should land at roughly similar time.
On 2015/05/27 10:17:34, Paweł Hajdan Jr. wrote: > What's going on with failures to compile without patch at > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... > , e.g. > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... > ? The ARM build is indeed broken right now :( http://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM/ This is exactly the kind of breakage that this change should prevent in future. I'll get it fixed. > > I'd also like to see a CL to move corresponding bot to main waterfall from FYI, > and then the changes should land at roughly similar time. Sure thing.
On 2015/05/27 17:09:29, Sam Clegg wrote: > On 2015/05/27 10:17:34, Paweł Hajdan Jr. wrote: > > What's going on with failures to compile without patch at > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... > > , e.g. > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... > > ? > > The ARM build is indeed broken right now :( > http://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM/ > > This is exactly the kind of breakage that this change should prevent in future. > I'll get it fixed. > > > > > > I'd also like to see a CL to move corresponding bot to main waterfall from > FYI, > > and then the changes should land at roughly similar time. > > Sure thing. ARM build is now fixed: https://codereview.chromium.org/1158133003 Move to the main waterfall can follow, but I think it required a new slave: https://codereview.chromium.org/1158703005/
There are still problems, see e.g. http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... Please make sure the CL to move ARM bot to main waterfall is ready to submit before proceeding.
On 2015/06/01 10:59:05, Paweł Hajdan Jr. wrote: > There are still problems, see e.g. > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... > This recent history looks all green to me: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile As does the FYI bot: http://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM The issue with build 7735 looks like an issue with the NaCl compilers not being found in goma (I think there is a delay there). The previous and following builds were green. I don't think this has anything to do with the ARM builder but just a goma issue what would have effected all builders (the nacl compiler is the same all linux builders). > Please make sure the CL to move ARM bot to main waterfall is ready to submit > before proceeding. OK, I guess you mean I should get a bot allocated. Will do.
On 2015/06/01 16:55:07, Sam Clegg wrote: > On 2015/06/01 10:59:05, Paweł Hajdan Jr. wrote: > > There are still problems, see e.g. > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi... > > > > This recent history looks all green to me: > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile > > As does the FYI bot: > http://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM > > The issue with build 7735 looks like an issue with the NaCl compilers not being > found in goma (I think there is a delay there). The previous and following > builds were green. I don't think this has anything to do with the ARM builder > but just a goma issue what would have effected all builders (the nacl compiler > is the same all linux builders). > > > Please make sure the CL to move ARM bot to main waterfall is ready to submit > > before proceeding. > > OK, I guess you mean I should get a bot allocated. Will do. Done.
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139963003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
Than main waterfall change is already made, so this bot is now based on the main waterfall bot: http://build.chromium.org/p/chromium.linux/builders/Linux%20ARM This is the final change needed to make it officially part of the CQ!
LGTM Please note I've asked for both changes to be landed at the same time. :-/
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139963003/40001
On 2015/06/10 09:32:54, Paweł Hajdan Jr. wrote: > LGTM > > Please note I've asked for both changes to be landed at the same time. :-/ Sorry, I actually thought you wanted this one landed first, but since you LGd the other first I assumed you were ok with that one landing first. Thanks for all your help on this! I've been trying to get are on the main waterfall for more than 2 years now :)
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a2caf9a3a0cb9d0f79c028af3aa7122e90912a7d Cr-Commit-Position: refs/heads/master@{#333738}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1295893004/ by jam@chromium.org. The reason for reverting is: This configuration is very flaky now. BUG=521162,521165. |
