Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1139953004: [Password Manager] Fix bug in IsEnabledSmartLockBranding (Closed)

Created:
5 years, 7 months ago by vabr (Chromium)
Modified:
5 years, 7 months ago
Reviewers:
engedy
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Fix bug in IsEnabledSmartLockBranding R=engedy@chromium.org BUG=400674, 486739 Committed: https://crrev.com/8b2f729dc8a46d096f8438f6c0a4156da4560f96 Cr-Commit-Position: refs/heads/master@{#330119}

Patch Set 1 #

Patch Set 2 : password_manager:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/passwords/password_bubble_experiment.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
vabr (Chromium)
Hi Balázs, PTAL. Thanks! Vaclav
5 years, 7 months ago (2015-05-15 16:28:10 UTC) #1
engedy
LGTM. We should verify that this is the only call site.
5 years, 7 months ago (2015-05-15 16:30:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139953004/1
5 years, 7 months ago (2015-05-15 16:31:21 UTC) #4
vabr (Chromium)
On 2015/05/15 16:30:16, engedy wrote: > LGTM. We should verify that this is the only ...
5 years, 7 months ago (2015-05-15 16:33:37 UTC) #5
vabr (Chromium)
New patch set, now with more compiling!
5 years, 7 months ago (2015-05-15 16:37:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139953004/20001
5 years, 7 months ago (2015-05-15 16:38:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 17:15:49 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 17:16:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b2f729dc8a46d096f8438f6c0a4156da4560f96
Cr-Commit-Position: refs/heads/master@{#330119}

Powered by Google App Engine
This is Rietveld 408576698