Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1139943003: Dying RenderProcessHostImpls should not send observer notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Represents the browser side of the browser <--> renderer communication 5 // Represents the browser side of the browser <--> renderer communication
6 // channel. There will be one RenderProcessHost per renderer process. 6 // channel. There will be one RenderProcessHost per renderer process.
7 7
8 #include "content/browser/renderer_host/render_process_host_impl.h" 8 #include "content/browser/renderer_host/render_process_host_impl.h"
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 2302 matching lines...) Expand 10 before | Expand all | Expand 10 after
2313 // is fixed. 2313 // is fixed.
2314 tracked_objects::ScopedTracker tracking_profile7( 2314 tracked_objects::ScopedTracker tracking_profile7(
2315 FROM_HERE_WITH_EXPLICIT_FUNCTION( 2315 FROM_HERE_WITH_EXPLICIT_FUNCTION(
2316 "465841 RenderProcessHostImpl::OnProcessLaunched::EnableAec")); 2316 "465841 RenderProcessHostImpl::OnProcessLaunched::EnableAec"));
2317 if (WebRTCInternals::GetInstance()->aec_dump_enabled()) 2317 if (WebRTCInternals::GetInstance()->aec_dump_enabled())
2318 EnableAecDump(WebRTCInternals::GetInstance()->aec_dump_file_path()); 2318 EnableAecDump(WebRTCInternals::GetInstance()->aec_dump_file_path());
2319 #endif 2319 #endif
2320 } 2320 }
2321 2321
2322 void RenderProcessHostImpl::OnProcessLaunchFailed() { 2322 void RenderProcessHostImpl::OnProcessLaunchFailed() {
2323 // If this object will be destructed soon, then observers have already been
2324 // sent a RenderProcessHostDestroyed notification, and we must observe our
2325 // contract that says that will be the last call.
2326 if (deleting_soon_)
2327 return;
2328
2323 RendererClosedDetails details { base::TERMINATION_STATUS_PROCESS_WAS_KILLED, 2329 RendererClosedDetails details { base::TERMINATION_STATUS_PROCESS_WAS_KILLED,
2324 -1 }; 2330 -1 };
2325 ProcessDied(true, &details); 2331 ProcessDied(true, &details);
2326 } 2332 }
2327 2333
2328 scoped_refptr<AudioRendererHost> 2334 scoped_refptr<AudioRendererHost>
2329 RenderProcessHostImpl::audio_renderer_host() const { 2335 RenderProcessHostImpl::audio_renderer_host() const {
2330 return audio_renderer_host_; 2336 return audio_renderer_host_;
2331 } 2337 }
2332 2338
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
2454 if (worker_ref_count_ == 0) 2460 if (worker_ref_count_ == 0)
2455 Cleanup(); 2461 Cleanup();
2456 } 2462 }
2457 2463
2458 void RenderProcessHostImpl::GetAudioOutputControllers( 2464 void RenderProcessHostImpl::GetAudioOutputControllers(
2459 const GetAudioOutputControllersCallback& callback) const { 2465 const GetAudioOutputControllersCallback& callback) const {
2460 audio_renderer_host()->GetOutputControllers(callback); 2466 audio_renderer_host()->GetOutputControllers(callback);
2461 } 2467 }
2462 2468
2463 } // namespace content 2469 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698