Prototype an 'allow-unsandboxed-auxiliary' sandbox flag.

Source/core/page/CreateWindow.cpp

Index: Source/core/page/CreateWindow.cpp
diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp
index 6eed43947714ea6c10c8327c63fdd8a65c2cfa5c..f388df34f5c9b987a6d08bd4f565eba86e96ba33 100644
--- a/Source/core/page/CreateWindow.cpp
+++ b/Source/core/page/CreateWindow.cpp
@@ -118,7 +118,8 @@ static LocalFrame* createWindow(LocalFrame& openerFrame, LocalFrame& lookupFrame
     host->chrome().setWindowRect(windowRect);
     host->chrome().show(policy);
 
-    frame.loader().forceSandboxFlags(openerFrame.document()->sandboxFlags());
+    if (openerFrame.document()->isSandboxed(SandboxUnsandboxedAuxiliary))

[philipj_slow, 2015/05/13 10:36:19]

The name is quite cryptic in this context. If you sandbox something unsandboxed,
it's no longer unsandboxed... Since the meaning is inverted from the syntax,
something like SandboxAuxiliaryBrowsingContexts would be clearer, but that would
make it harder to find this code if you just know the syntax.

No suggestion for how to make this better, just hoping you have an idea :)

[Mike West, 2015/05/13 11:22:01]

That's a fair point. Maybe something like
"SandboxPropagatesToAuxiliaryBrowsingContexts"? That seems more consistent with
the way flags are defined in HTML (I assume this would end up as something like
"Sandbox Propagates to Auxiliary Browsing Contexts flag" in
https://html.spec.whatwg.org/multipage/browsers.html#sandboxing). *shrug*

[philipj_slow, 2015/05/13 12:29:04]

That name is much more clear for now, thanks!

+        frame.loader().forceSandboxFlags(openerFrame.document()->sandboxFlags());
 
     created = true;
     return &frame;