Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 113993006: Fix duplicated images when editing pictures. (Closed)

Created:
7 years ago by mtomasz
Modified:
7 years ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix duplicated images when editing pictures. This is a recent regression after refactoring the gallery at: https://codereview.chromium.org/109973002/. The root cause of the duplication was an wrong if-check. TEST=Tested manually, according to the bug's repro steps. The problem is gone. BUG=328827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
7 years ago (2013-12-19 08:45:38 UTC) #1
hirono
On 2013/12/19 08:45:38, mtomasz wrote: > @hirono: PTAL. Thanks! Sorry for missing it. lgtm!
7 years ago (2013-12-19 08:48:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/113993006/1
7 years ago (2013-12-20 02:16:37 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-20 07:38:02 UTC) #4
Message was sent while issue was closed.
Change committed as 242031

Powered by Google App Engine
This is Rietveld 408576698