Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139923006: Move PepperOutputProtectionMessageFilter::Delegate to OutputProtectionDelegate. (Closed)

Created:
5 years, 7 months ago by xhwang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, ddorwin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PepperOutputProtectionMessageFilter::Delegate to OutputProtectionDelegate. BUG=479843 Committed: https://crrev.com/70e99e874f9c6db94106db77ee9e802ecaa7f0e4 Cr-Commit-Position: refs/heads/master@{#330485}

Patch Set 1 #

Patch Set 2 : rebase only #

Total comments: 4

Patch Set 3 : comments addressed #

Total comments: 10

Patch Set 4 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -468 lines) Patch
A chrome/browser/chromeos/display/output_protection_delegate.h View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/display/output_protection_delegate.cc View 1 2 3 9 chunks +29 lines, -227 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 1 5 chunks +8 lines, -233 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
xhwang
PTAL
5 years, 7 months ago (2015-05-16 00:04:51 UTC) #2
xhwang
rebase only
5 years, 7 months ago (2015-05-16 00:47:59 UTC) #3
kcwu
lgtm nits https://codereview.chromium.org/1139923006/diff/20001/chrome/browser/chromeos/display/output_protection_delegate.h File chrome/browser/chromeos/display/output_protection_delegate.h (right): https://codereview.chromium.org/1139923006/diff/20001/chrome/browser/chromeos/display/output_protection_delegate.h#newcode9 chrome/browser/chromeos/display/output_protection_delegate.h:9: #include "content/public/browser/render_frame_host.h" move to .cc? https://codereview.chromium.org/1139923006/diff/20001/chrome/browser/chromeos/display/output_protection_delegate.h#newcode47 chrome/browser/chromeos/display/output_protection_delegate.h:47: ...
5 years, 7 months ago (2015-05-16 12:45:43 UTC) #4
xhwang
comments addressed
5 years, 7 months ago (2015-05-18 18:25:56 UTC) #5
xhwang
https://codereview.chromium.org/1139923006/diff/20001/chrome/browser/chromeos/display/output_protection_delegate.h File chrome/browser/chromeos/display/output_protection_delegate.h (right): https://codereview.chromium.org/1139923006/diff/20001/chrome/browser/chromeos/display/output_protection_delegate.h#newcode9 chrome/browser/chromeos/display/output_protection_delegate.h:9: #include "content/public/browser/render_frame_host.h" On 2015/05/16 12:45:43, kcwu wrote: > move ...
5 years, 7 months ago (2015-05-18 18:30:44 UTC) #6
xhwang
mukai@chromium.org: Please review changes in chrome/browser/chromeos/display/output_protection_delegate.*. I am moving chromeos display specific code to chrome/browser/chromeos/display/. ...
5 years, 7 months ago (2015-05-18 18:33:54 UTC) #8
xhwang
+raymes for the OWNERS review in case bbudge is OOO.
5 years, 7 months ago (2015-05-19 00:26:53 UTC) #10
raymes
pepper lgtm
5 years, 7 months ago (2015-05-19 01:00:07 UTC) #11
Jun Mukai
+oshima mostly nits. https://codereview.chromium.org/1139923006/diff/40001/chrome/browser/chromeos/display/output_protection_delegate.cc File chrome/browser/chromeos/display/output_protection_delegate.cc (right): https://codereview.chromium.org/1139923006/diff/40001/chrome/browser/chromeos/display/output_protection_delegate.cc#newcode17 chrome/browser/chromeos/display/output_protection_delegate.cc:17: #error This file is ChromeOS only. ...
5 years, 7 months ago (2015-05-19 04:10:31 UTC) #13
Jun Mukai
ah, I meant lgtm with nits.
5 years, 7 months ago (2015-05-19 04:11:32 UTC) #14
xhwang
comments addressed
5 years, 7 months ago (2015-05-19 05:28:34 UTC) #15
xhwang
https://codereview.chromium.org/1139923006/diff/40001/chrome/browser/chromeos/display/output_protection_delegate.cc File chrome/browser/chromeos/display/output_protection_delegate.cc (right): https://codereview.chromium.org/1139923006/diff/40001/chrome/browser/chromeos/display/output_protection_delegate.cc#newcode17 chrome/browser/chromeos/display/output_protection_delegate.cc:17: #error This file is ChromeOS only. On 2015/05/19 04:10:31, ...
5 years, 7 months ago (2015-05-19 05:29:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139923006/60001
5 years, 7 months ago (2015-05-19 05:59:47 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-19 06:18:35 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 06:20:24 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/70e99e874f9c6db94106db77ee9e802ecaa7f0e4
Cr-Commit-Position: refs/heads/master@{#330485}

Powered by Google App Engine
This is Rietveld 408576698