Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1139923004: Add the API key to the config service request. (Closed)

Created:
5 years, 7 months ago by jeremyim
Modified:
5 years, 7 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the API key to the config service request. Also store a version of the GURL with no query string for purposes of displaying on the net-internals#bandwidth page. BUG=466753 Committed: https://crrev.com/a924fbc722dc9ab048180bf77d80ee216f370d6a Cr-Commit-Position: refs/heads/master@{#330609}

Patch Set 1 #

Total comments: 2

Patch Set 2 : bengr CR comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc View 1 5 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jeremyim
PTAL!
5 years, 7 months ago (2015-05-15 22:27:21 UTC) #2
bengr
https://codereview.chromium.org/1139923004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h File components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h (right): https://codereview.chromium.org/1139923004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h#newcode158 components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h:158: GURL base_config_service_url_; Do you really need this? Can it ...
5 years, 7 months ago (2015-05-19 15:28:14 UTC) #3
jeremyim
https://codereview.chromium.org/1139923004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h File components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h (right): https://codereview.chromium.org/1139923004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h#newcode158 components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h:158: GURL base_config_service_url_; On 2015/05/19 15:28:13, bengr wrote: > Do ...
5 years, 7 months ago (2015-05-19 17:18:37 UTC) #4
bengr
lgtm
5 years, 7 months ago (2015-05-19 19:13:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139923004/20001
5 years, 7 months ago (2015-05-19 20:35:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 21:30:21 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:31:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a924fbc722dc9ab048180bf77d80ee216f370d6a
Cr-Commit-Position: refs/heads/master@{#330609}

Powered by Google App Engine
This is Rietveld 408576698