Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1139913009: Reland: vea_unittest: Calculate per-frame encode latency (Closed)

Created:
5 years, 7 months ago by Justin Chuang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: vea_unittest: Calculate per-frame encode latency This is a reland of https://crrev.com/1117853002, which failed to compile in CHECK_GT(size_t var, 0), and CHECK_LE(size_t var, 100) because the compiler handles the numeric literals as signed. So compiler complained about comparing signed and unsigned. This is fixed by using unsigned numeric literals like 0UL and 100UL. Calculates per-frame encode latency, which is basically the time delay from input of each VideoFrame (VEA::Encode()) to output of the corresponding BitstreamBuffer (VEA::Client::BitstreamBufferReady()). It calculates encode latency values at the 50th(median), 75th, and 95th percentiles. Also fix a wrong comment. BUG=345181 TEST=Check "Encode latency for the 50%/75%/95%" in output logs. Committed: https://crrev.com/5118a5b3cbe6f33936ebe320da56c7b84f339eb5 Cr-Commit-Position: refs/heads/master@{#330060}

Patch Set 1 : Direct cherrypick from 1117853002 #

Patch Set 2 : Change 100 to 100UL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -59 lines) Patch
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 28 chunks +134 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Justin Chuang
PTAL. Thanks.
5 years, 7 months ago (2015-05-15 07:07:59 UTC) #2
wuchengli
lgtm
5 years, 7 months ago (2015-05-15 07:34:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139913009/20001
5 years, 7 months ago (2015-05-15 07:50:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 07:57:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 07:58:21 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5118a5b3cbe6f33936ebe320da56c7b84f339eb5
Cr-Commit-Position: refs/heads/master@{#330060}

Powered by Google App Engine
This is Rietveld 408576698