Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1139913007: X87: [strong] Check arity of functions (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [strong] Check arity of functions port 3226e980200035f37c86fef4b11fb307e17764a2 (28346). original commit message: [strong] Check arity of functions In strong mode it is an error to call a function with too few arguments. This is enforced inside the ArgumentsAdaptorTrampoline. This does not yet handle rest parameter BUG= Committed: https://crrev.com/fecaed531be62416d977bd2b365f43058f7bf8ba Cr-Commit-Position: refs/heads/master@{#28387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-13 10:27:42 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-13 10:37:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139913007/1
5 years, 7 months ago (2015-05-13 10:37:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 11:15:50 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 11:15:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fecaed531be62416d977bd2b365f43058f7bf8ba
Cr-Commit-Position: refs/heads/master@{#28387}

Powered by Google App Engine
This is Rietveld 408576698