Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1139913006: Add a JavaScript REPL example (that works with terminals). (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
hansmuller
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments + array fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
A examples/js/repl.js View 1 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 7 months ago (2015-05-12 19:54:11 UTC) #1
hansmuller
This is very slick. I would use it! LGTM https://codereview.chromium.org/1139913006/diff/1/examples/js/repl.js File examples/js/repl.js (right): https://codereview.chromium.org/1139913006/diff/1/examples/js/repl.js#newcode77 examples/js/repl.js:77: ...
5 years, 7 months ago (2015-05-12 22:33:01 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/1139913006/diff/1/examples/js/repl.js File examples/js/repl.js (right): https://codereview.chromium.org/1139913006/diff/1/examples/js/repl.js#newcode77 examples/js/repl.js:77: resultString = "null"; On 2015/05/12 22:33:01, hansmuller wrote: ...
5 years, 7 months ago (2015-05-12 22:52:26 UTC) #3
viettrungluu
5 years, 7 months ago (2015-05-12 22:53:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79f3a4b9923cc77e7eb713b4ef66f6858846898d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698