content/common/gpu/gpu_channel_manager.cc - Issue 1139903005: Add PERSISTENT_MAP usage for GpuMemoryBuffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_channel_manager.cc

Issue 1139903005: Add PERSISTENT_MAP usage for GpuMemoryBuffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: persistentmap: . Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/gpu_channel_manager.cc

diff --git a/content/common/gpu/gpu_channel_manager.cc b/content/common/gpu/gpu_channel_manager.cc

index 4cec7cb3c8114656a0138f24c144935a56bebb1f..7d26d183995e29436a6fc077b8ab2c49d1397fed 100644

--- a/content/common/gpu/gpu_channel_manager.cc

+++ b/content/common/gpu/gpu_channel_manager.cc

@@ -81,7 +81,9 @@ class GpuChannelManagerMessageFilter : public IPC::MessageFilter {

gfx::GpuMemoryBufferType GetGpuMemoryBufferFactoryType() {

std::vector<gfx::GpuMemoryBufferType> supported_types;

- GpuMemoryBufferFactory::GetSupportedTypes(&supported_types);

+ // TODO(reveman): No support for native PERSISTENT_MAP. crbug.com/489438

+ GpuMemoryBufferFactory::GetSupportedTypes(gfx::GpuMemoryBuffer::MAP,

+ &supported_types);

DCHECK(!supported_types.empty());

return supported_types[0];

}