Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1139903005: Add PERSISTENT_MAP usage for GpuMemoryBuffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: persistentmap: fixmandolinebetter Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 14006ce388f2c59fd6e83ec6256919e5f01b3bba..e3092f8cb1951e0d34d5efba560f4d86be0a475d 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1137,10 +1137,21 @@ static void AppendCompositorCommandLineFlags(base::CommandLine* command_line) {
if (IsForceGpuRasterizationEnabled())
command_line->AppendSwitch(switches::kForceGpuRasterization);
+ // TODO(reveman): We currently assume that the compositor will use BGRA_8888
+ // if it's able to, and RGBA_8888 otherwise. Since we don't know what it will
+ // use we hardcode BGRA_8888 here for now. We should instead move decisions
+ // about GpuMemoryBuffer format to the browser embedder so we know it here,
+ // and pass that decision to the compositor.
+ gfx::GpuMemoryBuffer::Format format = gfx::GpuMemoryBuffer::BGRA_8888;
+
+ command_line->AppendSwitchASCII(
+ switches::kMapImageTextureTarget,
+ base::UintToString(BrowserGpuChannelHostFactory::GetImageTextureTarget(
+ format, gfx::GpuMemoryBuffer::MAP)));
command_line->AppendSwitchASCII(
- switches::kUseImageTextureTarget,
- base::UintToString(
- BrowserGpuChannelHostFactory::GetImageTextureTarget()));
+ switches::kPersistentMapImageTextureTarget,
+ base::UintToString(BrowserGpuChannelHostFactory::GetImageTextureTarget(
+ format, gfx::GpuMemoryBuffer::PERSISTENT_MAP)));
// Appending disable-gpu-feature switches due to software rendering list.
GpuDataManagerImpl* gpu_data_manager = GpuDataManagerImpl::GetInstance();

Powered by Google App Engine
This is Rietveld 408576698