Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: android_webview/tools/webview_licenses.py

Issue 1139903004: [Android WebView] Prune the prune_paths list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/tools/webview_licenses.py
diff --git a/android_webview/tools/webview_licenses.py b/android_webview/tools/webview_licenses.py
index 05736f34bc7cd084f9bb92f2202706d84b13b5cd..d280eb674446fb00046d36539b288e7daef6c079 100755
--- a/android_webview/tools/webview_licenses.py
+++ b/android_webview/tools/webview_licenses.py
@@ -204,32 +204,15 @@ def _FindThirdPartyDirs():
# Please don't add here paths that have problems with license files,
# as they will end up included in Android WebView snapshot.
# Instead, add them into known_issues.py.
- prune_paths = [
- # Temporary until we figure out how not to check out quickoffice on the
- # Android license check bot. Tracked in crbug.com/350472.
- os.path.join('chrome', 'browser', 'resources', 'chromeos', 'quickoffice'),
- # Placeholder directory, no third-party code.
- os.path.join('third_party', 'adobe'),
+ prune_paths = set([
# Apache 2.0 license. See
# https://code.google.com/p/chromium/issues/detail?id=140478.
os.path.join('third_party', 'bidichecker'),
- # Isn't checked out on clients
- os.path.join('third_party', 'gles2_conform'),
- # The llvm-build doesn't exist for non-clang builder
- os.path.join('third_party', 'llvm-build'),
- # Binaries doesn't apply to android
- os.path.join('third_party', 'widevine'),
- # third_party directories in this tree aren't actually third party, but
- # provide a way to shadow experimental buildfiles into those directories.
- os.path.join('build', 'secondary'),
- # Not shipped, Chromium code
- os.path.join('tools', 'swarming_client'),
# Not shipped, only relates to Chrome for Android, but not to WebView
os.path.join('clank'),
- # Bots only, is not a part of the build
- os.path.join('isolate_deps_dir'),
- ]
- third_party_dirs = licenses.FindThirdPartyDirs(prune_paths, REPOSITORY_ROOT)
+ ])
+ third_party_dirs = licenses.FindThirdPartyDirs(
+ prune_paths | licenses.PRUNE_PATHS, REPOSITORY_ROOT)
return licenses.FilterDirsWithFiles(third_party_dirs, REPOSITORY_ROOT)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698