GN: component build was broken on unit_tests_main

GN: component build was broken on unit_tests_main

TEST=gn args out/gn --args="is_component_build=true"; \
    gn gen out/gn && ninja -C out/gn unit_tests_main
BUG=n/a

Committed: https://crrev.com/1b996ca6d9e1d1d9a6009fe146ea89cb922c632f
Cr-Commit-Position: refs/heads/master@{#329676}

[Takashi Toyoshima, 2015-05-12 07:40:13]

toyoshim@chromium.org changed reviewers:
+ andrewhayden@chromium.org, wez@chromium.org

[Takashi Toyoshima, 2015-05-12 07:42:30]

wez@ for chrome/browser/media/router.
andrewhayden@ for cld_2.

See https://code.google.com/p/chromium/issues/detail?id=444258#c40 and #c42 for
error details.

[andrewhayden, 2015-05-12 09:12:58]

The CQ bit was checked by andrewhayden@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-12 09:13:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139893003/1

[andrewhayden, 2015-05-12 09:14:15]

On 2015/05/12 07:42:30, Takashi Toyoshima (chromium) wrote:
> wez@ for chrome/browser/media/router.
> andrewhayden@ for cld_2.
> 
> See https://code.google.com/p/chromium/issues/detail?id=444258#c40 and #c42
for
> error details.

LGTM technically, but I'd like to understand why the Media Router unit tests
have a transitive dependency upon CLD. It has been a long time since I made the
change to include CLD's static stuff in the unit test world, but I don't think
it's a core thing... so yes to fix the build, but also I'll try to dig up why
this is required at all.

[Takashi Toyoshima, 2015-05-12 09:40:57]

I think GN component build works are not completed yet, and some targets for
some platforms often get broken, or have been broken. But IIRC, I can pass ninja
all with the same configuration a few days ago.

Wez, do you have any idea on media/router side?

[commit-bot: I haz the power, 2015-05-12 09:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-12 09:51:44]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2015-05-13 05:51:09]

toyoshim@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Takashi Toyoshima, 2015-05-13 05:51:45]

+dalecurtis for media just in case wez being busy

[Takashi Toyoshima, 2015-05-13 08:34:27]

This seems to have been broken only on debug build. The unused dependency to the
cld looks removed by optimization in release build.

[DaleCurtis, 2015-05-13 17:15:11]

lgtm

[Andrew Hayden (chromium.org), 2015-05-13 17:35:57]

The CQ bit was checked by andrewhayden@chromium.org

[commit-bot: I haz the power, 2015-05-13 17:36:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139893003/1

[commit-bot: I haz the power, 2015-05-13 18:11:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-13 18:12:21]

Patchset 1 (id:??) landed as
https://crrev.com/1b996ca6d9e1d1d9a6009fe146ea89cb922c632f
Cr-Commit-Position: refs/heads/master@{#329676}