Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139883006: Mandoline: Move content_handler.mojom from third_party/ to mojo/. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: Move content_handler.mojom from third_party/ to mojo/. mojo.ContentHandler is a core thing used by the shell, and thus should be part of the Application interface. This should enable further refactoring. BUG= Committed: https://crrev.com/5f027e9bda509d9bd23d91859cd6c3a54ca35808 Cr-Commit-Position: refs/heads/master@{#330540}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -47 lines) Patch
M components/html_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_document.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/interfaces/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
A + mojo/application/public/interfaces/content_handler.mojom View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/runner/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/shell/shell_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo_services/src/content_handler/public/interfaces/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/mojo_services/src/content_handler/public/interfaces/content_handler.mojom View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
5 years, 7 months ago (2015-05-18 23:22:09 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-19 00:08:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139883006/20001
5 years, 7 months ago (2015-05-19 17:09:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 17:16:50 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:18:39 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5f027e9bda509d9bd23d91859cd6c3a54ca35808
Cr-Commit-Position: refs/heads/master@{#330540}

Powered by Google App Engine
This is Rietveld 408576698