Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139873004: Make android directory for Android-specific bits of SkyShell (Closed)

Created:
5 years, 7 months ago by abarth-chromium
Modified:
5 years, 7 months ago
Reviewers:
Chinmay
CC:
mojo-reviews_chromium.org, gregsimon, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org, eseidel
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make android directory for Android-specific bits of SkyShell This CL prepares us to create an iOS version of SkyShell by moving the Android-specific bits into an android directory. R=chinmaygarde@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9a0f0b72785573ea8acdea1e235ed8a5dcbf515d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1123 lines) Patch
M sky/shell/BUILD.gn View 3 chunks +23 lines, -22 lines 0 comments Download
A + sky/shell/android/library_loader.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/GestureProvider.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/PlatformServiceProvider.java View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/PlatformView.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/ServiceFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/ServiceRegistry.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/SkyActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/SkyApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/SkyMain.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/TracingController.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/platform_service_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
A sky/shell/android/platform_service_provider.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A + sky/shell/android/platform_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/platform_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sky/shell/android/sky_main.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/sky_main.cc View 3 chunks +4 lines, -2 lines 0 comments Download
A + sky/shell/android/tracing_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/android/tracing_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D sky/shell/java_service_provider.h View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/shell/java_service_provider.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/shell/library_loader.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/GestureProvider.java View 1 chunk +0 lines, -136 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/JavaServiceProvider.java View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/PlatformView.java View 1 chunk +0 lines, -189 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/ServiceFactory.java View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/ServiceRegistry.java View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/SkyActivity.java View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/SkyApplication.java View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/SkyMain.java View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/shell/org/domokit/sky/shell/TracingController.java View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/shell/platform_view.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/shell/platform_view.cc View 1 chunk +0 lines, -81 lines 0 comments Download
A sky/shell/service_provider.h View 1 chunk +36 lines, -0 lines 0 comments Download
M sky/shell/shell.h View 2 chunks +6 lines, -8 lines 0 comments Download
M sky/shell/shell.cc View 4 chunks +7 lines, -7 lines 0 comments Download
D sky/shell/sky_main.h View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/shell/sky_main.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/shell/tracing_controller.h View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/shell/tracing_controller.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M sky/shell/ui/engine.h View 3 chunks +2 lines, -2 lines 0 comments Download
M sky/shell/ui/engine.cc View 3 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 7 months ago (2015-05-19 16:19:46 UTC) #1
Chinmay
lgtm. Thanks, was already adding the iOS specific stuff in sky/shell/ios. This makes the dir ...
5 years, 7 months ago (2015-05-19 16:37:30 UTC) #2
abarth-chromium
5 years, 7 months ago (2015-05-19 16:41:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9a0f0b72785573ea8acdea1e235ed8a5dcbf515d.

Powered by Google App Engine
This is Rietveld 408576698