Issue 1139833003: [test] Refactoring: Remove code duplication in perf runner.

Issue 1139833003: [test] Refactoring: Remove code duplication in perf runner. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach

Modified:
5 years, 7 months ago

Reviewers:
kjellander_chromium, tandrii(chromium)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[test] Refactoring: Remove code duplication in perf runner. BUG=484208 LOG=n TBR=kjellander@chromium.org NOTRY=true Committed: https://crrev.com/5db7ae47971b07c75922ee9114078608a2f4288f Cr-Commit-Position: refs/heads/master@{#28451}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	tools/run_perf.py	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 8 (2 generated)

Michael Achenbach

PTAL. Code dup removed. Fragile base class problem introduced...

5 years, 7 months ago (2015-05-13 13:59:02 UTC) #2

tandrii(chromium)

lgtm though in this very case, i don't see huge diff either way.

5 years, 7 months ago (2015-05-13 15:03:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139833003/1

5 years, 7 months ago (2015-05-18 15:03:40 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 15:11:27 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5db7ae47971b07c75922ee9114078608a2f4288f
Cr-Commit-Position: refs/heads/master@{#28451}