Issue 1139823010: Plumb display metrics into SkyView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1139823010: Plumb display metrics into SkyView (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Plumb display metrics into SkyView This CL teaches SkyView the width, height, and device pixel ratio of the display. In the future, we'll want some sort of notification system for when these values change. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/482dc250d6a68b4513b29023f2ba6f2111b43cc4

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -26 lines)			Patch
M	sky/engine/core/view/View.h	View	2 chunks	+8 lines, -0 lines	1 comment	Download
M	sky/engine/core/view/View.cpp	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	sky/engine/core/view/View.idl	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	sky/engine/public/platform/sky_display_metrics.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/public/sky/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/public/sky/sky_display_metrics.h	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	sky/engine/public/sky/sky_view.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	sky/engine/public/sky/sky_view.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/examples/raw/hello_world.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	4 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/1139823010/diff/1/sky/engine/core/view/View.h File sky/engine/core/view/View.h (right): https://codereview.chromium.org/1139823010/diff/1/sky/engine/core/view/View.h#newcode24 sky/engine/core/view/View.h:24: double width() const; We're going to want a ...

5 years, 7 months ago (2015-05-19 21:51:54 UTC) #2

abarth-chromium

5 years, 7 months ago (2015-05-19 21:54:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
482dc250d6a68b4513b29023f2ba6f2111b43cc4 (presubmit successful).

Expand Messages | Collapse Messages