Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1139823009: Move recordSelectorStats out of CSSSelectorParser API (Closed)

Created:
5 years, 7 months ago by rwlbuis
Modified:
5 years, 7 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move recordSelectorStats out of CSSSelectorParser API Now that the old CSS parser is gone, there is no reason to expose recordSelectorStats in the public CSSSelectorParser interface. BUG=489144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M Source/core/css/parser/CSSSelectorParser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 2 chunks +46 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 7 months ago (2015-05-22 21:23:04 UTC) #2
Timothy Loh
On 2015/05/22 21:23:04, rwlbuis wrote: > PTAL lgtm
5 years, 7 months ago (2015-05-23 04:41:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139823009/1
5 years, 7 months ago (2015-05-23 10:17:41 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 11:34:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195826

Powered by Google App Engine
This is Rietveld 408576698