Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1139823008: Re-enable ForceReclaimResources w/ ui impl side painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make expectations more constrained Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index d5e6ad6871d758ac363791e23d77d28e384d95dc..5cd78bc78a4b8a550750925a927720de3504902e 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -297,9 +297,12 @@ void LayerTreeHostImpl::BeginCommit() {
TRACE_EVENT0("cc", "LayerTreeHostImpl::BeginCommit");
// Ensure all textures are returned so partial texture updates can happen
- // during the commit. Impl-side-painting doesn't upload during commits, so
- // is unaffected.
- if (!settings_.impl_side_painting && output_surface_)
+ // during the commit.
+ // TODO(ericrk): We should not need to ForceReclaimResources when using
+ // Impl-side-painting as it doesn't upload during commits. However,
+ // Display::Draw currently relies on resource being reclaimed to block drawing
+ // between BeginCommit / Swap. See crbug.com/489515.
+ if (output_surface_)
output_surface_->ForceReclaimResources();
if (settings_.impl_side_painting && !proxy_->CommitToActiveTree())
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698