content/browser/frame_host/navigation_entry_impl.cc - Issue 1139823006: Ensure that unique ids are unique.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1139823006: Ensure that unique ids are unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl.cc

diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc

index c2b7675519eedc753a6aaa720c64f54fb45f489f..8cf430fca0c5cb266e7e0731d28be7832519f050 100644

--- a/content/browser/frame_host/navigation_entry_impl.cc

+++ b/content/browser/frame_host/navigation_entry_impl.cc

@@ -341,8 +341,8 @@ NavigationEntryImpl* NavigationEntryImpl::Clone() const {

// the same tab.

copy->frame_tree_.reset(frame_tree_->Clone());

- // Copy all state over, unless cleared in ResetForCommit.

- copy->unique_id_ = unique_id_;

+ // Copy most state over, unless cleared in ResetForCommit.

+ // Don't copy unique_id_, otherwise it won't be unique.

copy->bindings_ = bindings_;

copy->page_type_ = page_type_;

copy->virtual_url_ = virtual_url_;