Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1139823006: Ensure that unique ids are unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index c2b7675519eedc753a6aaa720c64f54fb45f489f..282d860a45a8d9e3a8ebbd22dba8f09f9a30da9f 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -342,7 +342,7 @@ NavigationEntryImpl* NavigationEntryImpl::Clone() const {
copy->frame_tree_.reset(frame_tree_->Clone());
// Copy all state over, unless cleared in ResetForCommit.
Peter Kasting 2015/05/18 20:49:23 Nit: all -> most
Avi (use Gerrit) 2015/05/18 20:51:43 Done.
- copy->unique_id_ = unique_id_;
+ // Not unique_id_; even identical twins have different fingerprints.
Peter Kasting 2015/05/18 20:49:23 Nit: Perhaps "Don't copy |unique_id_|, or it won't
Avi (use Gerrit) 2015/05/18 20:51:43 Done.
copy->bindings_ = bindings_;
copy->page_type_ = page_type_;
copy->virtual_url_ = virtual_url_;

Powered by Google App Engine
This is Rietveld 408576698