Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1139823005: Fix crash in shutdown of cast_shell browser process (Closed)

Created:
5 years, 7 months ago by halliwell
Modified:
5 years, 7 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in shutdown of cast_shell browser process Ensure that aura::Env is destroyed after CastBrowserProcess's members. During shutdown, CastBrowserProcess destructor can end up calling aura::Window::~Window (via application destruction and RenderWidgetHostImpl::Destroy), which needs access to the aura::Env instance. BUG= internal b/21156227 Committed: https://crrev.com/d14567b9de030b52377027c368f15be0942d8259 Cr-Commit-Position: refs/heads/master@{#330107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chromecast/browser/cast_browser_process.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
halliwell
5 years, 7 months ago (2015-05-15 15:48:42 UTC) #2
gunsch
lgtm, but where do we create the Aura instance? Is it lazily created for us ...
5 years, 7 months ago (2015-05-15 15:57:20 UTC) #3
halliwell
On 2015/05/15 15:57:20, gunsch wrote: > lgtm, but where do we create the Aura instance? ...
5 years, 7 months ago (2015-05-15 16:01:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139823005/1
5 years, 7 months ago (2015-05-15 16:25:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 16:36:36 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:37:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d14567b9de030b52377027c368f15be0942d8259
Cr-Commit-Position: refs/heads/master@{#330107}

Powered by Google App Engine
This is Rietveld 408576698